Add Navigation into the Japanese #1765
Conversation
AQIB-NAWAB
changed the title
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
There was a problem hiding this comment.
Hey @AQIB-NAWAB , the overall functionality is correct but I noticed a few checks are failing in this PR (related to Cypress). Please take a look and fix them. Thanks a lot!
github-project-automation
bot
moved this from Ready to review
to Changes requested
in PR - Triage Group
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1765 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 29 29
Lines 548 548
Branches 158 158
=========================================
Hits 548 548 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@Utkarsh-123github I made changes.Mostly of changes are according to @Deepak-cell311 PR. |
There was a problem hiding this comment.
Hi @AQIB-NAWAB , the functionality and code changes look great, nice work!
Just a small thing: I noticed there are a few extra spaces in the lib/slugifyMarkdownHeadline.ts file. Could you please format both the files once? After that, it's all good to go for merging.
|
Hi @Utkarsh-123github , please review |
|
Hey @AQIB-NAWAB ,I was caught up with some other work, but I’ll make sure to review your PR this weekend. Thanks for your patience! |
Thanks @Utkarsh-123github |
Utkarsh-123github
moved this from Changes requested
to Waiting for others to Review
in PR - Triage Group
|
@AQIB-NAWAB thanks a lot for this PR. Can you please fix the merge conflicts so that we can proceed with merging? |
benjagm
moved this from Waiting for others to Review
to Changes requested
in PR - Triage Group
What kind of change does this PR introduce?
This PR allows navigation in Japnese language
Issue Number:
Screenshots/videos:
Screencast from 2025-07-09 09-58-51.webm
If relevant, did you update the documentation?
Summary
Previously navigation was not working in the blog due to Japanese language. This pr fixed that issue.
Does this PR introduce a breaking change?
No
Checklist
Please ensure the following tasks are completed before submitting this pull request.